🎉 Source Stripe: extend schema for events.request field #8992

grubberr · 2021-12-21T13:08:31Z

Signed-off-by: Sergey Chvalyuk [email protected]

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Signed-off-by: Sergey Chvalyuk <[email protected]>

grubberr · 2021-12-21T13:10:09Z

/test connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/1606914550
✅ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/1606914550
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	   self._warn("No data was collected.", slug="no-data-collected")
	 Name                        Stmts   Miss  Cover
	 -----------------------------------------------
	 source_stripe/__init__.py       2      2     0%
	 source_stripe/source.py        22     22     0%
	 source_stripe/streams.py      195    195     0%
	 -----------------------------------------------
	 TOTAL                         219    219     0%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                        Stmts   Miss  Cover
	 -----------------------------------------------
	 source_stripe/__init__.py       2      0   100%
	 source_stripe/source.py        22     11    50%
	 source_stripe/streams.py      195     80    59%
	 -----------------------------------------------
	 TOTAL                         219     91    58%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        76      8    89%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     24    56%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  981    442    55%

Signed-off-by: Sergey Chvalyuk <[email protected]>

antixar

Looks good!
Please publish your changes.

grubberr · 2021-12-22T18:26:09Z

/test connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/1612564607
❌ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/1612564607
🐛 https://gradle.com/s/nmidjexoxfqri

grubberr · 2021-12-22T19:07:06Z

/test connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/1612693569
✅ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/1612693569
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                        Stmts   Miss  Cover
	 -----------------------------------------------
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------/actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-stripe/.venv/lib/python3.8/site-packages/coverage/control.py:768: CoverageWarning: No data was collected. (no-data-collected)
	 source_stripe/__init__.py       2      2     0%
	 source_stripe/source.py        22     22     0%
	 source_stripe/streams.py      195    195     0%
	 -----------------------------------------------
	 TOTAL                         219    219     0%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                        Stmts   Miss  Cover
	 -----------------------------------------------
	 source_stripe/__init__.py       2      0   100%
	 source_stripe/source.py        22     11    50%
	 source_stripe/streams.py      195     80    59%
	 -----------------------------------------------
	 TOTAL                         219     91    58%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      6    92%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38      0   100%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     17    69%
	 source_acceptance_test/utils/compare.py                 62     23    63%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  979    404    59%

grubberr · 2021-12-22T20:00:23Z

/publish connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/1612856748
✅ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/1612856748

Signed-off-by: Sergey Chvalyuk <[email protected]>

jagannathsrs · 2021-12-22T21:10:20Z

Hey @grubberr , thanks for the quick fix! Although it does not seem to have resolved the issue. I changed the Stripe version to 0.1.26 and ran the sync and getting the same error again.

grubberr · 2021-12-22T21:15:06Z

Hello @jagannathsrs, is it possible you DROP all tables on snowflake and do full_refresh sync again?
I am not sure how it works if snowflake already has old tables with outdated structure.

jagannathsrs · 2021-12-22T21:41:11Z

That and a schema_refresh from the UI worked. Apologies.

Thank you again!

events.request oneOf ["string", "object"]

676e928

Signed-off-by: Sergey Chvalyuk <[email protected]>

grubberr self-assigned this Dec 21, 2021

github-actions bot added the area/connectors Connector related issues label Dec 21, 2021

grubberr linked an issue Dec 21, 2021 that may be closed by this pull request

🐛 Source stripe: events stream error parsing JSON #8803

Closed

jrhizor temporarily deployed to more-secrets December 21, 2021 13:12 Inactive

stripe.md updated

573c5b6

Signed-off-by: Sergey Chvalyuk <[email protected]>

github-actions bot added the area/documentation Improvements or additions to documentation label Dec 21, 2021

grubberr temporarily deployed to more-secrets December 21, 2021 13:29 Inactive

grubberr requested review from midavadim, antixar and annalvova05 December 21, 2021 13:32

annalvova05 approved these changes Dec 22, 2021

View reviewed changes

antixar approved these changes Dec 22, 2021

View reviewed changes

Merge branch 'master' into grubberr/8803-source-stripe

9d55c0b

grubberr temporarily deployed to more-secrets December 22, 2021 18:27 Inactive

jrhizor temporarily deployed to more-secrets December 22, 2021 18:28 Inactive

jrhizor temporarily deployed to more-secrets December 22, 2021 19:09 Inactive

jrhizor temporarily deployed to more-secrets December 22, 2021 20:02 Inactive

grubberr added 2 commits December 22, 2021 22:17

Merge branch 'master' into grubberr/8803-source-stripe

ed65413

source_specs.yaml updated

c12d086

Signed-off-by: Sergey Chvalyuk <[email protected]>

grubberr temporarily deployed to more-secrets December 22, 2021 20:22 Inactive

grubberr merged commit 20a569e into master Dec 22, 2021

grubberr deleted the grubberr/8803-source-stripe branch December 22, 2021 20:22

jrhizor mentioned this pull request Dec 27, 2021

Bump Airbyte version from 0.35.1-alpha to 0.35.2-alpha #9119

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 Source Stripe: extend schema for events.request field #8992

🎉 Source Stripe: extend schema for events.request field #8992

grubberr commented Dec 21, 2021 •

edited

Loading

grubberr commented Dec 21, 2021 •

edited by github-actions bot

Loading

antixar left a comment

grubberr commented Dec 22, 2021 •

edited by github-actions bot

Loading

grubberr commented Dec 22, 2021 •

edited by github-actions bot

Loading

grubberr commented Dec 22, 2021 •

edited by github-actions bot

Loading

jagannathsrs commented Dec 22, 2021

grubberr commented Dec 22, 2021

jagannathsrs commented Dec 22, 2021

🎉 Source Stripe: extend schema for events.request field #8992

🎉 Source Stripe: extend schema for events.request field #8992

Conversation

grubberr commented Dec 21, 2021 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

grubberr commented Dec 21, 2021 • edited by github-actions bot Loading

antixar left a comment

Choose a reason for hiding this comment

grubberr commented Dec 22, 2021 • edited by github-actions bot Loading

grubberr commented Dec 22, 2021 • edited by github-actions bot Loading

grubberr commented Dec 22, 2021 • edited by github-actions bot Loading

jagannathsrs commented Dec 22, 2021

grubberr commented Dec 22, 2021

jagannathsrs commented Dec 22, 2021

grubberr commented Dec 21, 2021 •

edited

Loading

grubberr commented Dec 21, 2021 •

edited by github-actions bot

Loading

grubberr commented Dec 22, 2021 •

edited by github-actions bot

Loading

grubberr commented Dec 22, 2021 •

edited by github-actions bot

Loading

grubberr commented Dec 22, 2021 •

edited by github-actions bot

Loading