fix postgres integration tests for stream casing/special characters #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrhizor
commented
Nov 11, 2020
| @@ -20,4 +20,5 @@ dependencies { | |||
| integrationTestImplementation "org.testcontainers:postgresql:1.15.0-rc2" | |||
|
|
|||
| implementation files(project(':airbyte-integrations:bases:base-java').airbyteDocker.outputs) | |||
| integrationTestImplementation files(project(':airbyte-integrations:bases:base-normalization').airbyteDocker.outputs) | |||
There was a problem hiding this comment.
please add this to the integrations you're working on
jrhizor
commented
Nov 11, 2020
| @@ -215,7 +216,7 @@ private static void writeStreamsWithNRecords(int minRecords, | |||
| int batchSize, | |||
| CloseableQueue<byte[]> writeBuffer, | |||
| String tmpTableName) { | |||
| InsertValuesStep3<Record, String, JSONB, OffsetDateTime> step = ctx.insertInto(table(tmpTableName), field("ab_id", String.class), | |||
| InsertValuesStep3<Record, String, JSONB, OffsetDateTime> step = ctx.insertInto(table(name(tmpTableName)), field("ab_id", String.class), | |||
There was a problem hiding this comment.
name adds escaping. This is really what we should be doing everywhere if we also want to be able to handle quotes.
cgardens
approved these changes
Nov 11, 2020
sherifnada
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes all case handling and special characters except
".