DO NOT MERGE PR to test parsing dataset names in bq #9282

mkhokh-33 · 2022-01-04T14:20:34Z

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed.

This change is

mkhokh-33 · 2022-01-04T14:40:53Z

/test connector=destination-bigquery

🕑 destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1654104710
✅ destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1654104710
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    13      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     124      6    95%
	 normalization/transform_catalog/reserved_keywords.py                 13      0   100%
	 normalization/transform_catalog/stream_processor.py                 494    313    37%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         146     32    78%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1199    501    58%

mkhokh-33 · 2022-01-04T14:41:20Z

/test connector=destination-bigquery-denormalized

🕑 destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1654106746
✅ destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1654106746
No Python unittests run

…te into parsing-dataset-names-in-bq

mkhokh-33 · 2022-01-17T11:32:50Z

/test connector=destination-bigquery

🕑 destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1707724215
✅ destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1707724215
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    13      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     155      8    95%
	 normalization/transform_catalog/reserved_keywords.py                 13      0   100%
	 normalization/transform_catalog/stream_processor.py                 520    333    36%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         148     34    77%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1258    525    58%

mkhokh-33 · 2022-01-17T11:33:07Z

/test connector=destination-bigquery-denormalized

🕑 destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1707725230
✅ destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1707725230
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    13      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     155      8    95%
	 normalization/transform_catalog/reserved_keywords.py                 13      0   100%
	 normalization/transform_catalog/stream_processor.py                 520    333    36%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         148     34    77%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1258    525    58%

mkhokh-33 · 2022-01-17T12:10:51Z

/publish connector=destination-bigquery

❌ destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1707870350

mkhokh-33 · 2022-01-17T12:11:13Z

/publish connector=destination-bigquery-denormalized

❌ destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1707871634

mkhokh-33 · 2022-01-17T12:19:36Z

/publish connector=destination-bigquery

❌ destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1707905986

mkhokh-33 · 2022-01-17T13:41:33Z

/publish connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1708238180
❌ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1708238180

mkhokh-33 · 2022-01-18T08:57:04Z

/publish connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1711836919
✅ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1711836919

mkhokh-33 · 2022-01-18T09:08:29Z

/publish connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1711886415
✅ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1711886415

koji-m added 11 commits December 1, 2021 22:14

add Dataset ID parse method

7f7b220

add BigQuery Destination unit test

69b510d

update change log

5d99d33

Merge branch 'master' into parsing-dataset-names-in-bq

ddd1425

fit to the latest code base

d3d9cda

update change log

f4ced62

change var name to const name

a3838eb

change public method to private

af80798

add test cases for testGetDatasetIdFail

4c78cb5

add integration test for dataset-id prefixed with project-id

7171871

Merge branch 'master' into parsing-dataset-names-in-bq

85ab152

github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jan 4, 2022

mkhokh-33 temporarily deployed to more-secrets January 4, 2022 14:21 Inactive

jrhizor temporarily deployed to more-secrets January 4, 2022 14:43 Inactive

mkhokh-33 temporarily deployed to more-secrets January 4, 2022 14:52 Inactive

mkhokh-33 temporarily deployed to more-secrets January 4, 2022 15:25 Inactive

mkhokh-33 mentioned this pull request Jan 4, 2022

Destination BigQuery: Accept Dataset ID field prefixed by Project ID #8383

Merged

16 tasks

fix getDatasetId

c505823

karinakuz added connectors/destination/bigquery connectors/destinations-api labels Jan 6, 2022

koji-m added 2 commits January 6, 2022 14:23

add comment to parameterized test provider

686e2c7

Merge branch 'parsing-dataset-names-in-bq' of github.com:koji-m/airby…

d4522f4

…te into parsing-dataset-names-in-bq

karinakuz added connectors/destinations-warehouse and removed connectors/destinations-api labels Jan 13, 2022

koji-m added 2 commits January 16, 2022 04:51

update docker image versions

6c26a63

update docker image versions again

25bf817

Merge branch 'master' into parsing-dataset-names-in-bq

5eefebe

mkhokh-33 temporarily deployed to more-secrets January 17, 2022 11:32 Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 17, 2022 11:34 Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 17, 2022 11:35 Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 17, 2022 12:15 Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 17, 2022 12:21 Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 17, 2022 13:43 Inactive

mkhokh-33 temporarily deployed to more-secrets January 18, 2022 08:38 Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 18, 2022 08:59 Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 18, 2022 09:10 Inactive

mkhokh-33 temporarily deployed to more-secrets January 18, 2022 09:41 Inactive

mkhokh-33 closed this Jan 18, 2022

swyxio deleted the test-parsing-dataset-names-in-bq branch October 12, 2022 18:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DO NOT MERGE PR to test parsing dataset names in bq #9282

DO NOT MERGE PR to test parsing dataset names in bq #9282

mkhokh-33 commented Jan 4, 2022 •

edited by lmossman

Loading

mkhokh-33 commented Jan 4, 2022 •

edited by github-actions bot

Loading

mkhokh-33 commented Jan 4, 2022 •

edited by github-actions bot

Loading

mkhokh-33 commented Jan 17, 2022 •

edited by github-actions bot

Loading

mkhokh-33 commented Jan 17, 2022 •

edited by github-actions bot

Loading

mkhokh-33 commented Jan 17, 2022 •

edited by github-actions bot

Loading

mkhokh-33 commented Jan 17, 2022 •

edited by github-actions bot

Loading

mkhokh-33 commented Jan 17, 2022 •

edited by github-actions bot

Loading

mkhokh-33 commented Jan 17, 2022 •

edited by github-actions bot

Loading

mkhokh-33 commented Jan 18, 2022 •

edited by github-actions bot

Loading

mkhokh-33 commented Jan 18, 2022 •

edited by github-actions bot

Loading

DO NOT MERGE PR to test parsing dataset names in bq #9282

DO NOT MERGE PR to test parsing dataset names in bq #9282

Conversation

mkhokh-33 commented Jan 4, 2022 • edited by lmossman Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

mkhokh-33 commented Jan 4, 2022 • edited by github-actions bot Loading

mkhokh-33 commented Jan 4, 2022 • edited by github-actions bot Loading

mkhokh-33 commented Jan 17, 2022 • edited by github-actions bot Loading

mkhokh-33 commented Jan 17, 2022 • edited by github-actions bot Loading

mkhokh-33 commented Jan 17, 2022 • edited by github-actions bot Loading

mkhokh-33 commented Jan 17, 2022 • edited by github-actions bot Loading

mkhokh-33 commented Jan 17, 2022 • edited by github-actions bot Loading

mkhokh-33 commented Jan 17, 2022 • edited by github-actions bot Loading

mkhokh-33 commented Jan 18, 2022 • edited by github-actions bot Loading

mkhokh-33 commented Jan 18, 2022 • edited by github-actions bot Loading

mkhokh-33 commented Jan 4, 2022 •

edited by lmossman

Loading

mkhokh-33 commented Jan 4, 2022 •

edited by github-actions bot

Loading

mkhokh-33 commented Jan 4, 2022 •

edited by github-actions bot

Loading

mkhokh-33 commented Jan 17, 2022 •

edited by github-actions bot

Loading

mkhokh-33 commented Jan 17, 2022 •

edited by github-actions bot

Loading

mkhokh-33 commented Jan 17, 2022 •

edited by github-actions bot

Loading

mkhokh-33 commented Jan 17, 2022 •

edited by github-actions bot

Loading

mkhokh-33 commented Jan 17, 2022 •

edited by github-actions bot

Loading

mkhokh-33 commented Jan 17, 2022 •

edited by github-actions bot

Loading

mkhokh-33 commented Jan 18, 2022 •

edited by github-actions bot

Loading

mkhokh-33 commented Jan 18, 2022 •

edited by github-actions bot

Loading