have compose build only depend on actual dependencies #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgardens
commented
Nov 12, 2020
| ].toSet().asImmutable() | ||
|
|
||
| if (project.name in composeDeps) { | ||
| composeBuild.dependsOn(project.tasks.assemble) |
There was a problem hiding this comment.
should i be depending on this? or on something like this? files(project(project.name).airbyteDocker.outputs
There was a problem hiding this comment.
your dependcy is correct right now
There was a problem hiding this comment.
building the image only depends on the jar. We might actually want to use the docker plugin here instead of docker compose.
There was a problem hiding this comment.
cool. thanks! going to merge as is and then we can move to the docker plugin after if we'd like.
|
output of -dry-run |
michel-tricot
approved these changes
Nov 12, 2020
| ].toSet().asImmutable() | ||
|
|
||
| if (project.name in composeDeps) { | ||
| composeBuild.dependsOn(project.tasks.assemble) |
There was a problem hiding this comment.
your dependcy is correct right now
| ].toSet().asImmutable() | ||
|
|
||
| if (project.name in composeDeps) { | ||
| composeBuild.dependsOn(project.tasks.assemble) |
There was a problem hiding this comment.
building the image only depends on the jar. We might actually want to use the docker plugin here instead of docker compose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #958
What
:composeBuilddepends on all integrations. It shouldn't. It only has a few real dependencies. Developing on the API or the webapp right now is really painful because of this.