Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kafka Destination issue Fixed. sasl_jaas_config #9905

Closed
wants to merge 2 commits into from
Closed

Kafka Destination issue Fixed. sasl_jaas_config #9905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f76199e
Kafka Source Destination issue Fixed :Not able to read kafka config "…
data-storyteller Jan 31, 2022
ef50d05
Kafka Source Destination issue Fixed :Not able to read kafka config "…
data-storyteller Jan 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-config/init/src/main/resources/seed/destination_definitions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
- name: Kafka
destinationDefinitionId: 9f760101-60ae-462f-9ee6-b7a9dafd454d
dockerRepository: airbyte/destination-kafka
dockerImageTag: 0.1.3
dockerImageTag: 0.1.4
documentationUrl: https://docs.airbyte.io/integrations/destinations/kafka
icon: kafka.svg
- name: Kinesis
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/destination-kafka/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ ENV APPLICATION destination-kafka

COPY --from=build /airbyte /airbyte

LABEL io.airbyte.version=0.1.3
LABEL io.airbyte.version=0.1.4
LABEL io.airbyte.name=airbyte/destination-kafka
4 changes: 2 additions & 2 deletions ...kafka/src/main/java/io/airbyte/integrations/destination/kafka/KafkaDestinationConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,8 @@ private Map<String, Object> propertiesByProtocol(final JsonNode config) {
switch (protocol) {
case PLAINTEXT -> {}
case SASL_SSL, SASL_PLAINTEXT -> {
builder.put(SaslConfigs.SASL_JAAS_CONFIG, config.get("sasl_jaas_config").asText());
builder.put(SaslConfigs.SASL_MECHANISM, config.get("sasl_mechanism").asText());
builder.put(SaslConfigs.SASL_JAAS_CONFIG, protocolConfig.get("sasl_jaas_config").asText());
builder.put(SaslConfigs.SASL_MECHANISM, protocolConfig.get("sasl_mechanism").asText());
}
default -> throw new RuntimeException("Unexpected Kafka protocol: " + Jsons.serialize(protocol));
}
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/destinations/kafka.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ _NOTE_: Some configurations for SSL are not available yet.

| Version | Date | Pull Request | Subject |
| :--- | :--- | :--- | :--- |
| 0.1.4 | 2022-01-31 | [\#9905](https://github.com/airbytehq/airbyte/pull/9905) | Fix SASL config read issue |
| 0.1.3 | 2021-12-30 | [\#8809](https://github.com/airbytehq/airbyte/pull/8809) | Update connector fields title/description |
| 0.1.2 | 2021-09-14 | [\#6040](https://github.com/airbytehq/airbyte/pull/6040) | Change spec.json and config parser |
| 0.1.1 | 2021-07-30 | [\#5125](https://github.com/airbytehq/airbyte/pull/5125) | Enable `additionalPropertities` in spec.json |
Expand Down