Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDK: Ensure AirbyteLogger is thread-safe using Lock #9943

Merged
merged 2 commits into from
Feb 28, 2022
Merged

CDK: Ensure AirbyteLogger is thread-safe using Lock #9943

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ab5f62
Ensure AirbyteLogger is thread-safe
jdclarke5 Jan 31, 2022
61a8382
Revert lock and add deprecation warning instead
jdclarke5 Feb 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion airbyte-cdk/python/airbyte_cdk/logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
# Copyright (c) 2021 Airbyte, Inc., all rights reserved.
#

from deprecated import deprecated
import logging
import logging.config
import sys
Expand Down Expand Up @@ -101,7 +102,7 @@ def log_by_prefix(msg: str, default_level: str) -> Tuple[int, str]:

return log_level, rendered_message


@deprecated(version="0.1.47", reason="Use logging.getLogger('airbyte') instead")
class AirbyteLogger:
def log(self, level, message):
log_record = AirbyteLogMessage(level=level, message=message)
Expand Down