Implement other ZSTD compression levels #162 #172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IIRC the other compression techniques are not implemented, so this would not work.... basically, I think the constants are there but the implementations don't work or are missing. |
|
So it would involve implementing the alternate io.airlift.compress.zstd.CompressionParameters.Strategy classes in addition to DoubleFastBlockCompressor for DFAST? I can see that some of those would be... very much non trivial (backs away from BTOPT), but could this be done in stages? - so implementing GREEDY could unlock compression Level 4, FAST could unlock 1 & 2 etc? David |
|
Indeed, it would require implementing the other BlockCompressor strategies. They could certainly be added incrementally, as you suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement of issue #162 (#162)