-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding remote Config / AB testing to app #1440
base: staging
Are you sure you want to change the base?
Conversation
@BenjaminSsempala try to merge staging into your branch so that we get a tests coverage report |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## staging #1440 +/- ##
===========================================
+ Coverage 9.24% 10.76% +1.51%
===========================================
Files 369 159 -210
Lines 9892 10907 +1015
Branches 1951 0 -1951
===========================================
+ Hits 915 1174 +259
- Misses 8284 9733 +1449
+ Partials 693 0 -693 ☔ View full report in Codecov by Sentry. |
WalkthroughWalkthroughThe recent changes introduce Firebase Remote Config to the mobile application. A new Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
mobile/pubspec.lock
is excluded by!**/*.lock
Files selected for processing (3)
- mobile/lib/main.dart (1 hunks)
- mobile/lib/main_common.dart (2 hunks)
- mobile/pubspec.yaml (1 hunks)
Files skipped from review due to trivial changes (1)
- mobile/pubspec.yaml
Additional comments not posted (3)
mobile/lib/main.dart (1)
36-37
: LGTM! The integration of remoteConfigSetup is correctly placed.The
remoteConfigSetup
function is called after Firebase initialization, ensuring proper setup.mobile/lib/main_common.dart (2)
24-24
: Import statement is correct.The
firebase_remote_config
package import is necessary for using the remote configuration features.
144-155
: Function implementation is correct.The
remoteConfigSetup
function initializes remote config settings with appropriate timeouts and default values. The function implementation follows best practices.
Summary of Changes (What does this PR do?)
Status of maturity (all need to be checked before merging):
How should this be manually tested?
What are the relevant tickets?
Screenshots (optional)
Summary by CodeRabbit