Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PEP-8 violations reported by flake8 on test/benchmark folder #1000

Merged
merged 6 commits into from
Feb 8, 2022
Merged

Fix PEP-8 violations reported by flake8 on test/benchmark folder #1000

merged 6 commits into from
Feb 8, 2022

Conversation

LucyJimenez
Copy link
Contributor

Check flake8 and fix pep8 issues related on :

  • cache_examples.py
  • code_extraction.py
  • params_examples.py
  • subdir/time_subdir.py
  • time_examples.py
  • time_secondary.py
  • timeraw_examples.py

@LucyJimenez LucyJimenez changed the title Fix PEP-8 violations reported by flake8 Fix PEP-8 violations reported by flake8 on test/benchmark folder Jan 31, 2022
datapythonista
datapythonista reviewed Jan 31, 2022
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Added few comments.

We also need to rebase (merge master into your branch) and add the fixed files to be checked by flake8.

test/benchmark/params_examples.py Outdated
@@ -3,24 +3,28 @@

from __future__ import (absolute_import, division, print_function)

import os
import os # noqa F401 unused import
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why not to remove this import if it's unused?

test/benchmark/subdir/time_subdir.py Outdated
@@ -1,4 +1,4 @@
import time
import time # noqa F401 unused import
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

test/benchmark/timeraw_examples.py Outdated
Comment on lines 7 to 8
import inspect # Checked below. # noqa F401 unused import
import sys # noqa F401 unused import
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@LucyJimenez LucyJimenez marked this pull request as draft February 2, 2022 13:02
@LucyJimenez LucyJimenez marked this pull request as ready for review February 2, 2022 13:42
@LucyJimenez LucyJimenez closed this Feb 6, 2022
@LucyJimenez LucyJimenez deleted the flake8_issue7 branch February 6, 2022 02:47
@LucyJimenez LucyJimenez restored the flake8_issue7 branch February 6, 2022 02:47
@LucyJimenez LucyJimenez reopened this Feb 8, 2022
datapythonista
datapythonista approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LucyJimenez, looks great, ping me om green.

@datapythonista datapythonista merged commit 5685e00 into airspeed-velocity:master Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datapythonista datapythonista datapythonista approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LucyJimenez @datapythonista