-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PEP-8 violations reported by flake8 on asv/step_detect.py #1006
Fix PEP-8 violations reported by flake8 on asv/step_detect.py #1006
Conversation
For all those |
Hi @datapythonista, thank you for your insight. I'm going to back all the |
@datapythonista the PR is ready to review. I also created the issue #1008 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @LucyJimenez looks great.
setup.cfg
Outdated
ignore = | ||
W504, # W504: Line break occurred after a binary operator | ||
E741 # E741: Do not use variables named 'I', 'O', or 'l |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment with a TODO pointing to the issue you created, so there is more context of why we ignore this error code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ye, I'll do it!
Can you rebase please? |
ignore = | ||
W504, # W504: Line break occurred after a binary operator | ||
E741 # E741: Do not use variables named 'I', 'O', or 'l' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you create an issue to fix the E741
errors on github, and in a follow up PR add a comment above this line with the issue number please.
Thanks @LucyJimenez for the clean up |
closes https://github.com/pandas-benchmarks-grant/board-issues/issues/6
Fix PEP-8 violations reported by flake8 on asv/step_detect.py