Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Flake8 violations for files in the test/ directory #1091

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Fix Flake8 violations for files in the test/ directory #1091

merged 1 commit into from
Mar 3, 2022

Conversation

LucyJimenez
Copy link
Contributor

@LucyJimenez LucyJimenez commented Mar 3, 2022 •
edited
Loading

xref #1042
Fix pep8 issues on:

  • test_benchmarks.py
  • test_step_detect.py

@LucyJimenez
Copy link
Contributor Author

LucyJimenez commented Mar 3, 2022 •
edited
Loading

@datapythonista The issue #1042 has many files to review, and each has pep8 several problems. I will work between 2-3 files per PR. This one is now ready to review. Thank you.

@datapythonista datapythonista merged commit 7c7efc0 into airspeed-velocity:master Mar 3, 2022
@datapythonista
Copy link
Member

Thanks @LucyJimenez, and yes, thanks for splitting this in multiple PRs, much better for everyone.

@datapythonista
Copy link
Member

I'd probably update setup.cfg in each PR, and keep removing the files that are fixed and can be validated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LucyJimenez @datapythonista