Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move fixture from test/test_step_detect.py file #1131

Merged

Conversation

dorothykiz1
Copy link
Contributor

xref #1030

@dorothykiz1
Copy link
Contributor Author

dorothykiz1 commented Mar 10, 2022

@datapythonista I ran isort locally on this particular file seems fine but complains here , could it be skipping the imports with inline comments? Is there a way to not skip imports with comments? Below is the error returned;

ERROR: /home/runner/work/asv/asv/test/test_step_detect.py Imports are incorrectly sorted and/or formatted.
Skipped 1 files
Error: Process completed with exit code 1.

@datapythonista
Copy link
Member

@datapythonista I ran isort locally on this particular file seems fine but complains here , could it be skipping the imports with inline comments? Is there a way to not skip imports with comments? Below is the error returned;

ERROR: /home/runner/work/asv/asv/test/test_step_detect.py Imports are incorrectly sorted and/or formatted.
Skipped 1 files
Error: Process completed with exit code 1.

Can you better comment in the relevant part of the code? It's making my life unnecessarily harder to have to read your comment in one tab, and switch to another and find the exact part you're taling about, to see what code you're referring to. Thanks!

@dorothykiz1
Copy link
Contributor Author

Let me do this

@datapythonista datapythonista merged commit fd9f3ac into airspeed-velocity:master Mar 12, 2022
@datapythonista
Copy link
Member

Thanks @dorothykiz1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants