-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Cleanup with asv_runner
#1287
Conversation
At the moment, if "matrix": {
"req": {
"pympler": []
},
}, then |
This is a backwards incompatible change. Since |
pyproject.toml
Outdated
@@ -25,6 +25,7 @@ dynamic = [ | |||
"version", | |||
] | |||
dependencies = [ | |||
"asvcore", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is the asvcore package on PyPI created? Is it from this repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently it's over here:
https://github.com/HaoZeke/asvcore
If the PR and implementation looks good the next step would be to migrate it to the airspeed-velocity organization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a design document somewhere with how these pieces fit together: what belongs in asvcore and what remains in asv? I am not sure I understand the division.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The design and separation is described a bit in #1286
Where is the pyproject.toml for asvcore? It seems the PyPI entry is missing metadata like the repo, where to file issues, ... |
For now:
Yup I thought it would be better to fill those out once it's migrated to the airspeed-velocity organization instead of where it is now (a repo under my github handle). |
assert len(b) == 36 | ||
if util.ON_PYPY: | ||
assert len(b) == 34 | ||
else: | ||
assert len(b) == 36 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattip and I discussed that perhaps later it might make sense to have a mechanism for discovering all benchmarks, and then skipping or mark as fail or something where it isn't feasible to run.
Currently this design is because the regex is part of the classes and in the new approach the benchmark types are dynamically populated.
The |
93e6ebc
to
010588a
Compare
MAINT: Silence linter
Incredibly the |
@mattip can we go ahead and merge this since the test failures have been fixed? The rest of the issues (documentation, repo location) can be worked on after that. |
This is a big change. Does it have some echo in the documentation? Maybe here? |
@mattip I've added some documentation, and also started working on API documentation for Let me know if it looks alright / what specific questions are not addressed :) |
Proof of concept implementation of #1286.What's left is:[ ] Add a configuration option to select additional benchmarksmem
pympler
in a backwards compatible mannerAdding additional benchmarks should be handled elsewhere, maybe in #1283, since for BC reasons,
mem
andpympler
shouldn't have to be selected by users.Closes #1286.
EDIT: Updated the name of the core repository