Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Test on min/max supported ranges of python versions #1366

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

dstansby
Copy link
Contributor

This updates the test matrix to make sure tests are run on every supported Python version. Also updates the Python 3.12 tests to use the released instead of release candidate version.

@mattip
Copy link
Contributor

mattip commented Jan 17, 2024

This adde 3 more runs: python3.8, python3.9, python3.11, and brings the count from 5 run to 8. I think we don't really need that, and it is enough to test all python versions in the wheel builds.

The changes to the pyproject.toml are good, but not really part of this PR (in case anyone thinks of closing this).

@dstansby
Copy link
Contributor Author

dstansby commented Jan 17, 2024

What would be a preferred testing strategy? To test on minimum and maximum Python version (currently 3.7 and 3.12) instead? If time is an issue with the new test runs, note that they run in parallel so shouldn't add any extra testing time.

@mattip
Copy link
Contributor

mattip commented Jan 17, 2024

they run in parallel

While that may be true it is a waste of resources generously donated by github. Is there a particular concern you have with something in asv that may be fragile across python versions?

I would be happy to test with a single version of CPython and a single version of PyPy. When building wheels for a release, we build the package for all version of python, so in the unlikely case of version-specificy breakage, the problem will be caught then.

@dstansby
Copy link
Contributor Author

Certainly for new versions of Python there are removals and deprecations, so it would be nice to test that asv is working on the latest version of cPython. And then my thinking is it's good to test against the oldest version too, to prevent someone accidentally using API introduced in e.g. Python 3.11 that would break support for Python 3.7.

@dstansby dstansby changed the title Test on full supported ranges of python versions Test on min/max supported ranges of python versions Jan 17, 2024
Copy link
Member

@HaoZeke HaoZeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rework the commit to have MAINT: ?

@HaoZeke HaoZeke changed the title Test on min/max supported ranges of python versions CI: Test on min/max supported ranges of python versions Jan 27, 2024
@HaoZeke HaoZeke merged commit 37bb44b into airspeed-velocity:main Feb 1, 2024
11 checks passed
@HaoZeke
Copy link
Member

HaoZeke commented Feb 1, 2024

Thanks @dstansby 🚀

@dstansby dstansby deleted the python-ver-tests branch February 1, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants