Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Finalize rename to main #1375

Merged
merged 5 commits into from
Feb 4, 2024
Merged

Conversation

HaoZeke
Copy link
Member

@HaoZeke HaoZeke commented Feb 1, 2024

Part of #1368.

@HaoZeke HaoZeke force-pushed the postRename branch 2 times, most recently from 4c33ddf to 8dc2289 Compare February 1, 2024 15:26
@HaoZeke HaoZeke marked this pull request as draft February 1, 2024 15:38
@HaoZeke HaoZeke mentioned this pull request Feb 1, 2024
@HaoZeke HaoZeke marked this pull request as ready for review February 1, 2024 20:00
@HaoZeke HaoZeke requested a review from mattip February 1, 2024 20:00
@mattip
Copy link
Contributor

mattip commented Feb 2, 2024

Could you add a release note? I think this could have an impact on projects that still use `master' as the default branch: they will need to now use a non-default configuration, right?

@HaoZeke
Copy link
Member Author

HaoZeke commented Feb 2, 2024

Could you add a release note? I think this could have an impact on projects that still use `master' as the default branch: they will need to now use a non-default configuration, right?

I'm not sure it will though, if the projects have an existing asv.config.json they shouldn't be affected. Internally asv still assumes master even after this simply because asv shouldn't be responsible for making changes to git configurations and that still defaults to master. The default example config has changed, but that shouldn't be a breaking change.

I will add a release note.

@mattip mattip merged commit 5158973 into airspeed-velocity:main Feb 4, 2024
11 checks passed
@mattip
Copy link
Contributor

mattip commented Feb 4, 2024

Thanks @HaoZeke

@mattip
Copy link
Contributor

mattip commented Feb 4, 2024

The release note can be part of the general release

@HaoZeke HaoZeke deleted the postRename branch February 4, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants