Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codespell config, pre-commit hook, and GH action (to catch new typos) + make it fix some it finds #1392

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

yarikoptic
Copy link
Contributor

@yarikoptic yarikoptic commented Mar 20, 2024

TODO

  • remove TEMP commit after seeing if pre-commit workflow catches it
  • remove github action if pre-commit wf catches it

@yarikoptic
Copy link
Contributor Author

ok, pre-commit works but needs duplication for excludes. I might just exclude that specific name... and we do not need dedicated GH action -- will remove it.

@yarikoptic yarikoptic marked this pull request as ready for review March 20, 2024 01:00
Copy link
Member

@HaoZeke HaoZeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could the commits be reworded with a MAINT: tag? (and also squashed, I think one MAINT: commit adding the config and one DOC: using it should suffix).

Sorry for the delayed review!

@yarikoptic
Copy link
Contributor Author

done -- one commit rebased and squashed now

@yarikoptic
Copy link
Contributor Author

Failing CI runs seems to not relate

@HaoZeke HaoZeke merged commit 6cc8f94 into airspeed-velocity:main Jun 4, 2024
11 of 14 checks passed
@HaoZeke
Copy link
Member

HaoZeke commented Jun 4, 2024

Thanks @yarikoptic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants