ENH add ncores field to asv-machine #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pv
requested changes
Oct 24, 2018
asv/machine.py
Outdated
| @@ -144,6 +149,7 @@ def get_defaults(): | |||
| return { | |||
| 'machine': node, | |||
| 'os': "{0} {1}".format(system, release), | |||
| 'ncores': os.cpu_count(), | |||
There was a problem hiding this comment.
Should work on Python 2 still.
Also, should be six.text_type, not int.
asv/machine.py
Outdated
| @@ -119,6 +119,11 @@ class Machine(object): | |||
| including its speed and class. For example, 'Intel(R) | |||
| Core(TM) i5-2520M CPU @ 2.50GHz (4 cores)'."""), | |||
|
|
|||
| ("ncores", | |||
There was a problem hiding this comment.
num_cpu? Not going to bikeshed though if there's good reason to not call it that.
There was a problem hiding this comment.
Actually I like more num_cpu, but it felt weird to use underscores in command line options.
|
thanks, merged (CI build failures due to conda flaking out again) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple PR to add the number of CPUs into
.asv-machine.json