Skip to content

Commit

Permalink
Disable source profile URI scrubbing in usnistgov#116.
Browse files Browse the repository at this point in the history
During testing, it became clear this URI scrubbing for the source-profile
prop in the resuling catalog is useful, but it scrubs the full path,
including the filename, not just the path itself. This behavior seems to
be divergent from previous behavior from the transforms, obsolete shell
scripting, or the combination of both. Local testing by changing calling
paths and other environmental changes did not seem to alter the behavior.

For now, I will leave the full path and during code review we can discuss
the merits of prioritizing the work in the backlog, using a workaround
in the Makefile and/or support shell scripting temporarily, or both
until the issue is resolved.
  • Loading branch information
aj-stein-nist committed Oct 27, 2023
1 parent d04ccf3 commit ccbb00c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion build/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ NPM_PREFIX_DIR:=oscal/build
NPM_PKGS_DIR:=node_modules
XSLT_RUNNER:=oscal/build/xslt-runner.sh
PROFILE_RESOLVER_RUNNER:=oscal/src/utils/resolver-pipeline/oscal-profile-resolve.sh
PROFILE_RESOLVER_ARGS:="hide-source-profile-uri=true" "uuid-method='random-xslt'"
PROFILE_RESOLVER_ARGS:="uuid-method='random-xslt'"
XML_JSON_CONVERTER_XSLT:=oscal/build/generated/oscal_complete_xml-to-json-converter.xsl
OSCAL_COMPLETE_XML_SCHEMA:=oscal/build/generated/oscal_complete_schema.xsd
OSCAL_COMPLETE_JSON_SCHEMA:=oscal/build/generated/oscal_complete_schema.json
Expand Down

0 comments on commit ccbb00c

Please sign in to comment.