Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progress bar CPU usage is high under very high concurrency #207

Closed
ajalt opened this issue Aug 18, 2024 · 0 comments · Fixed by #208
Closed

Progress bar CPU usage is high under very high concurrency #207

ajalt opened this issue Aug 18, 2024 · 0 comments · Fixed by #208

Comments

@ajalt
Copy link
Owner

ajalt commented Aug 18, 2024 •
edited
Loading

I ran the IntelliJ Profiler on my example above and added your spinlock fix, and I noticed that while update() did take a lot of time,

image

interestingly samples.dropWhile {} seems to take longer.

mordant/mordant/src/commonMain/kotlin/com/github/ajalt/mordant/animation/progress/MultiProgressBarAnimation.kt

Line 172 in 1660323

val samples = samples.dropWhile { it.time < oldestSampleTime } + entry

image

Flamegraph:

image

Originally posted by @aSemy in #204 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve performance of progress bars under high concurrency ajalt/mordant
1 participant
@ajalt