Improve performance of progress bars under high concurrency #208
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping track of progress history was taking a lot of CPU load if updates were happening very frequently.
@aSemy suggested an improvement in #204 (comment), and this PR goes further:
Instead of keeping a list with an entry for each call to
update
, we instead keep a fixed size list, and overwrite the last entry if it was very recent. We only look at the first and last entries to calculate speed, so there's no need to keep every entry.This change is a 350x speedup on the benchmarks I ran, which seems fast enough.
Fixes #207