Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL linebreaks #3840

Closed
dometto opened this issue Nov 28, 2018 · 2 comments · Fixed by #3842
Closed

RTL linebreaks #3840

dometto opened this issue Nov 28, 2018 · 2 comments · Fixed by #3842

Comments

@dometto
Copy link

dometto commented Nov 28, 2018

After merging #3658 I have the impression RTL support is almost complete in ACE. Remaining problem: at the moment, pressing enter while on an RTL line incorrectly produces a new LTR line.

Looking at the source, the RTL extension is supposed to prevent that with this function:
https://github.com/ajaxorg/ace/pull/3658/files#diff-39037390fecdb74f84f14bc14e4a5e1dR85
But that function never appears to be called (when I add a debug statement to it, it doesn't appear when I insert a newline on an RTL line). Am I doing something wrong, or is this a bug?

@nightwing
Copy link
Member

Thanks for reporting this issue, it was caused by a typo in the code adding change event handler.
This should be fixed by #3842 .
Please let us know about any other feature requests or issues you find!

@dometto
Copy link
Author

dometto commented Nov 28, 2018

Thanks for the quick fix @nightwing! What's the timetable on the next bugfix release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants