Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bidi support #3658

Merged
merged 3 commits into from
May 11, 2018
Merged

Fix bidi support #3658

merged 3 commits into from
May 11, 2018

Conversation

nightwing
Copy link
Member

No description provided.

commit 0caba83
Author: Alex Shensis <[email protected]>
Date:   Wed Oct 25 15:51:50 2017 +0300

    fix test error

commit 968d7e9
Author: Alex Shensis <[email protected]>
Date:   Sun Oct 22 20:54:19 2017 +0300

    fix syntax checks

commit 942b4eb
Merge: 40ccc5c 485cd35
Author: Alex Shensis <[email protected]>
Date:   Sun Oct 22 20:11:14 2017 +0300

    merge with upstream changes

commit 40ccc5c
Author: Alex Shensis <[email protected]>
Date:   Fri Oct 20 17:28:21 2017 +0300

    attend reviewer comments 2

commit 268da25
Author: Alex Shensis <[email protected]>
Date:   Thu Sep 7 21:10:29 2017 +0300

    right-to-left text direction support
@codecov
Copy link

codecov bot commented Apr 28, 2018

Codecov Report

Merging #3658 into master will increase coverage by 0.05%.
The diff coverage is 31.86%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3658      +/-   ##
=========================================
+ Coverage   66.44%   66.5%   +0.05%     
=========================================
  Files         478     478              
  Lines       47613   47671      +58     
  Branches     9061    9082      +21     
=========================================
+ Hits        31638   31705      +67     
+ Misses      15975   15966       -9
Impacted Files Coverage Δ
lib/ace/edit_session.js 82.61% <100%> (+0.77%) ⬆️
lib/ace/virtual_renderer.js 68.62% <100%> (+0.19%) ⬆️
lib/ace/lib/bidiutil.js 20.26% <25%> (+0.17%) ⬆️
lib/ace/bidihandler.js 30.05% <25.42%> (+2.37%) ⬆️
lib/ace/layer/marker.js 65.44% <40%> (-7.21%) ⬇️
lib/ace/layer/gutter.js 64.74% <0%> (+0.35%) ⬆️
lib/ace/layer/cursor.js 85.61% <0%> (+0.71%) ⬆️
lib/ace/line_widgets.js 57.67% <0%> (+14.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0155d37...ecd19f0. Read the comment docs.

@nightwing nightwing merged commit bcaca34 into master May 11, 2018
@nightwing nightwing deleted the fix-bidi-support branch May 11, 2018 16:52
@dometto
Copy link

dometto commented Nov 20, 2018

@nightwing thanks for this great PR. I have the impression RTL support almost works: at the moment, pressing enter while on an RTL line incorrectly produces a new LTR line. Looking at the source, the RTL extension is supposed to prevent that with this function:
https://github.com/ajaxorg/ace/pull/3658/files#diff-39037390fecdb74f84f14bc14e4a5e1dR85
But that function never appears to be called (when I add a debug statement to it, it doesn't appear when I insert a newline on an RTL line). Am I doing something wrong, or is this a bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants