-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bidi support #3658
Fix bidi support #3658
Conversation
commit 0caba83 Author: Alex Shensis <[email protected]> Date: Wed Oct 25 15:51:50 2017 +0300 fix test error commit 968d7e9 Author: Alex Shensis <[email protected]> Date: Sun Oct 22 20:54:19 2017 +0300 fix syntax checks commit 942b4eb Merge: 40ccc5c 485cd35 Author: Alex Shensis <[email protected]> Date: Sun Oct 22 20:11:14 2017 +0300 merge with upstream changes commit 40ccc5c Author: Alex Shensis <[email protected]> Date: Fri Oct 20 17:28:21 2017 +0300 attend reviewer comments 2 commit 268da25 Author: Alex Shensis <[email protected]> Date: Thu Sep 7 21:10:29 2017 +0300 right-to-left text direction support
26cdbc0
to
ecd19f0
Compare
Codecov Report
@@ Coverage Diff @@
## master #3658 +/- ##
=========================================
+ Coverage 66.44% 66.5% +0.05%
=========================================
Files 478 478
Lines 47613 47671 +58
Branches 9061 9082 +21
=========================================
+ Hits 31638 31705 +67
+ Misses 15975 15966 -9
Continue to review full report at Codecov.
|
@nightwing thanks for this great PR. I have the impression RTL support almost works: at the moment, pressing enter while on an RTL line incorrectly produces a new LTR line. Looking at the source, the RTL extension is supposed to prevent that with this function: |
No description provided.