Added changes to integrade cpu AC to ResourceUsageCollector and Emit Stats #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 18, 2023 12:18
Signed-off-by: Ajay Kumar Movva <[email protected]>
…ed AdmissionController Signed-off-by: Ajay Kumar Movva <[email protected]>
Signed-off-by: Ajay Kumar Movva <[email protected]>
Signed-off-by: Ajay Kumar Movva <[email protected]>
Signed-off-by: Ajay Kumar Movva <[email protected]>
Signed-off-by: Ajay Kumar Movva <[email protected]>
ajaymovva
changed the title
| in -> new ConcreteShardRequest<>(requestReader, in), | ||
| this::handlePrimaryRequest | ||
| ); | ||
| if(transportPrimaryAction.equals(TransportShardBulkAction.ACTION_NAME + PRIMARY_ACTION_SUFFIX)){ |
There was a problem hiding this comment.
Lets add a comment why we are doing this
| /** | ||
| * Map to store the actions based on the type of the transport operation | ||
| */ | ||
| public class AdmissionControlActionsMap { |
| @@ -60,8 +68,8 @@ public void initialise() { | |||
| /** | |||
| * Handler to trigger registered admissionController | |||
There was a problem hiding this comment.
Lets add comments for method parameters as well , as action is mainly needed for debugging in this case
| /** | ||
| * | ||
| * @param settings Immutable settings instance | ||
| * @param clusterSettings ClusterSettings Instance | ||
| * @param clusterService ClusterSettings Instance |
There was a problem hiding this comment.
Same comment everywhere - lets update comments to reflect the function parameters
| return false; | ||
| } | ||
|
|
||
| private long getMaxCPULimitForAction(AdmissionControlActionType transportActionType) { |
| */ | ||
| @Override | ||
| public void writeTo(StreamOutput out) throws IOException { | ||
| if (out.getVersion().onOrAfter(Version.CURRENT)) { |
There was a problem hiding this comment.
Use same version constant in both in and out
ajaymovva
force-pushed
the
feature/admission-controller
branch
11 times, most recently
from
b8c2c63
to
fa39f9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.