Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve hotkeys functionality and resolve related issues #323

Merged
merged 11 commits into from
Nov 5, 2024

Conversation

stone-lyl
Copy link
Collaborator

@stone-lyl stone-lyl commented Oct 28, 2024

Regarding the SHIFT+ issue, most of it is related to React Flow. You can find more details in this PR: xyflow/xyflow#4761
This PR temporarily uses a hacky approach to work around the issue.

H1:

H1.mp4

H2:

H2.mp4

H3-H6

H3-H6.mp4

H8: The functionality to navigate between nodes using the keyboard arrows (up/down/left/right) has been restored, but I find the logic odd.

H8.mp4

Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
data-story-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 9:48am

@stone-lyl stone-lyl merged commit 334d2c6 into ajthinking:main Nov 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant