Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify generated code for "side-effects only" custom keywords #393

Closed
epoberezkin opened this issue Jan 5, 2017 · 1 comment
Closed

Simplify generated code for "side-effects only" custom keywords #393

epoberezkin opened this issue Jan 5, 2017 · 1 comment
Labels
enhancement

Comments

@epoberezkin
Copy link
Member

epoberezkin commented Jan 5, 2017 •
edited
Loading

See #141 (comment)

If keyword always returns the same validation result and is used for side-effects (mutating data, logging, accumulation, updating errors, etc.) passing validation result via keyword definition (valid: true/false) would both simplify the keyword function (no need to return true) and substantially simplify the generated code - e.g., no need to define/return error that is only used in case validation fails.
@epoberezkin epoberezkin added this to the 5.0.0 milestone Jan 5, 2017
epoberezkin added a commit that referenced this issue Jan 20, 2017
@epoberezkin
feat: custom keywords with predefined validation result, #393
aa8de57
epoberezkin added a commit that referenced this issue Jan 20, 2017
@epoberezkin
docs: update typings for "modifying" and "valid" custom keywords, #392,
7148ae3 
#393
@epoberezkin
Copy link
Member Author

In 4.11.0 and 5.0.1-beta.1

@epoberezkin epoberezkin removed this from the 5.0.0 milestone Jan 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

No branches or pull requests
1 participant
@epoberezkin