add refs variable for jtd validation #2316
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be some weird behavior with typescript when refs was left to default. By specifying it manually the behavior was fixed.
What issue does this pull request resolve?
fixes #2167
What changes did you make?
R extends Record<string, unknown>
to compile and validate for JTD schemas that resolves the referenced issue.--cache
to prettier invocation. This is not related to the diff, but a nice quality of life change. I'll remove if requestedIs there anything that requires more attention while reviewing?
--cache
to prettiercompile
andvalidate
have really complicated types. This change only resolved the existing tests, but we know coverage is not 100%, so if anything comes to mind that this might hurt.with or without cache, prettier was tweaking files that broke typescript. I reverted the changes here to get the pull request in, but it's worth calling out