Fix compatibility with Flynt 0.78 and 1.0.0 #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akaihola
force-pushed
the
flynt-0.78-compatibility
branch
from
a5f862c
to
0535cfb
Compare
akaihola
force-pushed
the
flynt-0.78-compatibility
branch
from
0535cfb
to
370a237
Compare
akaihola
force-pushed
the
flynt-0.78-compatibility
branch
from
370a237
to
524d05a
Compare
|
note that since this PR was started, flynt v1.0.0 has been released: https://github.com/ikamensh/flynt/releases/tag/1.0.0 |
akaihola
changed the title
akaihola
force-pushed
the
flynt-0.78-compatibility
branch
from
aebc873
to
25319c7
Compare
It produces those e.g. when `.format()` contains backslashes. The process still finishes and converts other parts of the code, so we can just ignore these.
akaihola
force-pushed
the
flynt-0.78-compatibility
branch
from
25319c7
to
c358893
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #472 and #541.
We temporarily limited Flynt to version 0.77 and earlier in version 1.7.1 (see #474). This patch fixes compatibility with Flynt 0.78 and 1.0.x.
masterflyntrelated test failure only on 3.7)