Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asd #7

Merged
merged 4 commits into from
Dec 14, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion public/menu.js
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ function setMainMenu(mainWindow) {
{
label: `About Version`,
click() {
shell.openExternal(`https://github.com/kamranahmedse/pennywise/releases/tag/${appVersion}`);
shell.openExternal(`https://github.com/kamranahmedse/pennywise/releases/tag/v${appVersion}`);
}
},
]
Expand Down
4 changes: 2 additions & 2 deletions readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Pennywise opens any website or media in a **small floating window that remains o
* **Resize and place** it anywhere
* **Shortcuts** to make you more productive
* Lets you **multitask** while you work
* **Opensource** licensed under MIT
* **Open source** licensed under MIT
* **Lean** small resource footprint, minimal User Interface.
* **Cross-platform** works on MacOS, Windows and Linux

Expand All @@ -39,7 +39,7 @@ brew cask install pennywise

## Usecases

> Here is the list of some of the possible usecases off the top of my head
> Here is the list of some of the possible use cases off the top of my head

* Use it as a floating window for your calendar/checklist/assigned-tickets etc
* Watching tutorial while you code? Open the video in Pennywise and keep it in front of you
Expand Down
2 changes: 1 addition & 1 deletion src/browser.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class Browser extends React.Component {
ipcRenderer.on('embedVideos.set', this.onembedVideosSet);
}

componentWillUnMount() {
componentWillUnmount() {
ipcRenderer.removeEventListener('embedVideos.set', this.onembedVideosSet);
}

Expand Down
24 changes: 19 additions & 5 deletions src/components/empty-page/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,24 @@
h1 {
font-weight: 700;
font-size: 55px;
margin-bottom: 10px;
margin-bottom: 1vh;
@media (max-height: 140px) {
display: none;
}
}

p {
font-size: 18px;
font-weight: 500;
@media (max-height: 190px) {
display: none;
}
}

input {
font-size: 18px;
font-weight: 500;
margin-top: 15px;
margin-top: 1.5vh;
padding: 15px 20px;
box-shadow: none;
border-radius: 80px;
Expand All @@ -35,9 +41,17 @@
}

svg {
width: 250px;
height: 250px;
margin-bottom: 20px;
width: 50vh;
margin-bottom: 2vh;
@media (max-height: 400px) {
width: 40vh;
}
@media (max-height: 320px) {
width: 30vh;
}
@media (max-height: 250px) {
display: none;
}
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/components/nav-bar/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ class NavBar extends Component {
ipcRenderer.on('nav.focus', this.focusUrlInput);
}

componentWillUnMount() {
componentWillUnmount() {
ipcRenderer.removeListener('nav.focus', this.focusUrlInput);
}

Expand Down