Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/track persistent storage #267

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Conversation

Redm4x
Copy link
Collaborator

@Redm4x Redm4x commented Jul 11, 2024

Track provider persistent storage

  • Store persistent storage information in the new ProviderSnapshotStorage table
  • Added columns for persistent storage to ProviderSnapshot and renamed the old ones to ephemeral.
  • Removed all stats columns from the Provider table. We recently added lastSnapshotId & lastSuccessfulSnapshotId on the Provider table and it is easy to get the stats from there.

⚠️ I did not implement persistent storage tracking for the REST status endpoint since almost all active providers have already migrated to GRPC.

@Redm4x Redm4x force-pushed the features/track-persistent-storage branch 2 times, most recently from 622eb8a to 6b297df Compare July 11, 2024 05:20
@Redm4x Redm4x marked this pull request as ready for review July 11, 2024 15:55
@Redm4x Redm4x force-pushed the features/track-persistent-storage branch from 6b297df to e0bdb46 Compare July 22, 2024 03:10
@Redm4x Redm4x force-pushed the features/track-persistent-storage branch from e0bdb46 to bc3d2c3 Compare July 22, 2024 05:14
@Redm4x Redm4x merged commit 1762ba6 into main Jul 23, 2024
5 checks passed
@Redm4x Redm4x deleted the features/track-persistent-storage branch July 23, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants