Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: persistent storage #1348

Merged
merged 2 commits into from
Oct 15, 2021
Merged

feat: persistent storage #1348

merged 2 commits into from
Oct 15, 2021

Conversation

troian
Copy link
Member

@troian troian commented Aug 17, 2021 •
edited
Loading

  1. update SDL to handle multiple storage requests
  2. use statefulSet when deployment needs persistent storage

Parts

  • SDL
  • Resource
  • Proto
  • Inventory
  • Attributes
  • Bidengine
  • Provider create/update
  • Manifest

tests

  • SDL
  • Resource
  • Manifest
  • K8S Integration

@troian troian mentioned this pull request Aug 17, 2021
Closed
12 tasks
hydrogen18
hydrogen18 reviewed Aug 18, 2021
View reviewed changes
provider/cluster/kube/builder/workload.go
},
}

if cpu := b.service.Resources.CPU; cpu != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is basically identical to what is on master, but do we actually have a case where this can be nil? Same question applies to memory below this. Thoughts @boz ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, good point. even with gpu only workloads cpu is required

arijitAD
arijitAD reviewed Aug 20, 2021
View reviewed changes
proto/akash/base/v1beta1/resource.proto Outdated Show resolved Hide resolved
provider/bidengine/provider_attributes.go Outdated Show resolved Hide resolved
provider/cluster/client.go Show resolved Hide resolved
provider/cluster/client.go Outdated Show resolved Hide resolved
provider/cluster/client.go Outdated Show resolved Hide resolved
@troian troian marked this pull request as ready for review August 22, 2021 23:35
@troian troian requested a review from boz as a code owner August 22, 2021 23:35
@troian troian mentioned this pull request Aug 22, 2021
Closed
@troian troian force-pushed the troian/storage branch 10 times, most recently from 61fddbf to 01837ac Compare August 27, 2021 12:01
@troian troian force-pushed the troian/storage branch 6 times, most recently from 1f08bcd to 71dfa52 Compare September 22, 2021 15:11
@troian troian force-pushed the troian/storage branch 7 times, most recently from acff6d9 to 6b6c0fb Compare September 29, 2021 21:54
@troian troian mentioned this pull request Sep 30, 2021
Open
@troian troian force-pushed the troian/storage branch 3 times, most recently from 2cdfaca to 540979d Compare October 5, 2021 15:14
@boz
Copy link
Contributor

boz commented Oct 7, 2021

What's going on with this one?

@troian troian force-pushed the troian/storage branch 6 times, most recently from 83969c0 to 9f0e203 Compare October 8, 2021 03:50
@troian
feat: persistent storage
0e487ff 
Signed-off-by: Artur Troian <[email protected]>
@troian troian merged commit 9d4ed2d into master Oct 15, 2021
@troian troian deleted the troian/storage branch October 15, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hydrogen18 hydrogen18 hydrogen18 left review comments

@arijitAD arijitAD arijitAD left review comments

@boz boz Awaiting requested review from boz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@troian @boz @hydrogen18 @arijitAD