Fixed date format before saving into database #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpasquin
approved these changes
Jun 6, 2023
|
@magentix Are there any specific reasons why this PR hasnt been added yet? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those changes fixes issue caused by 67f58c2
When
last_success_executed_datewas datetime it was saved correctly into the database. But by changing it into text Mysql is no longer fixing date format while saving into database.As result date is saved as
23-05-16 11:26:55instead of2023-05-16 11:26:55.When this date is used as filter in
Since last successful importProducts process it downloads all the products on each run of import instead of only modified.