Akka.Remote: log all layers of wrapped messages during errors #6818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure we capture what the real underlying message types are when we encounter issues like serialization errors, oversized payload exceptions, and so on.
Aaronontheweb
commented
Jun 28, 2023
| TestActor); | ||
|
|
||
| var loggedType = EndpointWriter.LogPossiblyWrappedMessageType(wrappedMessage); | ||
| loggedType.Should().Contain("DeadLetter").And.Contain("ActorSelectionMessage").And.Contain("String"); |
There was a problem hiding this comment.
Simple unit test to assert that our log formatting helper captures all of the layers correctly.
This test produces the following output in the log:
Akka.Event.DeadLetter-->(Akka.Actor.ActorSelectionMessage-->System.String)
| @@ -1486,7 +1522,7 @@ private bool WriteSend(EndpointManager.Send send) | |||
| string.Format("Discarding oversized payload sent to {0}: max allowed size {1} bytes, actual size of encoded {2} was {3} bytes.", | |||
| send.Recipient, | |||
| Transport.MaximumPayloadBytes, | |||
| send.Message.GetType(), | |||
| LogPossiblyWrappedMessageType(send.Message), | |||
There was a problem hiding this comment.
Captured all of the relevant EndpointWriter callsites here - unfortunately, on the EndpointReader side we don't know what the underlying type is because it fails during deserialization, which is where we would extract that kind of information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Make sure we capture what the real underlying message types are when we encounter issues like serialization errors, oversized payload exceptions, and so on.
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):