Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added meaningful ToString() to all system messages #695

Merged
merged 2 commits into from
Mar 1, 2015

Conversation

Horusiath
Copy link
Contributor

cc #72

Hope this will close the case.

@Aaronontheweb
Copy link
Member

@Horusiath I doubt these changes were the reason why the ThrottlerTransportAdapterSpec failed, so I queued up a new version of this build to run just to verify. Thanks for taking care of this!

@Aaronontheweb
Copy link
Member

Wow, that's not at all what I expected... Somehow these changes did effect these three tests consistently, even on different build servers. What could have caused that?

@rogeralsing
Copy link
Contributor

Found the issue..
It throws Null ref exception in Identify.ToString

  public override string ToString()
        {
            return "<Identify>: " + MessageId.ToString();
        }

Remove the ToString on messageId and it is fine

HCanber added a commit that referenced this pull request Mar 1, 2015
Added meaningful ToString() to all system messages
@HCanber HCanber merged commit 85d217f into akkadotnet:dev Mar 1, 2015
@Horusiath Horusiath deleted the sys-msg-to-string branch March 23, 2016 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants