Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script to add Copyright headers & modify files to add header #820

Merged
merged 10 commits into from
Apr 9, 2015

Conversation

SeanKilleen
Copy link
Contributor

In support of #718, this PR will contain two changes:

  • A PowerShell script in the tools directory that adds copyright files to .cs and .fs files that don't have them
  • A pass on every C# and F# file that adds in the new

@rogeralsing
Copy link
Contributor

Imo the C# line should be changed into a copyright line too, apache 2 license is clear on this matter, you own the modifications you make.

So something along the lines of

Copyright (C) 2009-2015 Typesafe Inc. <http://www.typesafe.com>
Copyright (C) 2013-2015 Akka.NET project <http://getakka.net/>

And personally, I'd rather see this github link instead of getakka.net.
As github is the actual source. people reading our source will most likely already know that we have a site.
Possibly link to this page: https://github.com/akkadotnet/akka.net/graphs/contributors

cc @akkadotnet/contributors @akkadotnet/developers thoughts on this?

@SeanKilleen
Copy link
Contributor Author

@rogeralsing for further reference, there appears to be a guide here.

Most examples I've seen so far involve adding some more text -- while the script is mostly ready to go, I won't run the script across all files until we finish the discussion -- #718 is likely a better place. I'm thinking.

Reflects changes from conversation in akkadotnet#718.
Generated via the script in the tools directory. The only changes made
to any files in this commit are the additions of comments in the
beginning.

Solution builds and all tests pass.
Because clicking a dialog every time a file is opened is not fun for
most people.
Generated via the script in the tools directory. All CS / FS files now
contain this copyright language.

The only changes made to the files in this commit are the addition of
the comments.

The build still works and all expected tests pass.
@SeanKilleen SeanKilleen changed the title Work in Progress: Script & Copyright Headers Script & Copyright Headers Apr 8, 2015
@SeanKilleen
Copy link
Contributor Author

@Aaronontheweb @rogeralsing ready for review.

@SeanKilleen SeanKilleen changed the title Script & Copyright Headers Script to add Copyright headers & modify files to add header Apr 8, 2015
@SeanKilleen
Copy link
Contributor Author

@rogeralsing @Aaronontheweb it occurs to me that this is a huge commit. While it builds and tests fine, would you prefer I break it up into smaller commits? I didn't see a problem at the time but let me know if you want me to revert this and commit several smaller chunks.

@Aaronontheweb
Copy link
Member

@SeanKilleen PR is fine as-is. I'm just waiting on getting the API docs stuff working perfectly before I pull this in, just because I'm going to have to make some on-the-fly adjustments to that script I suspect. I'll pull this in within a couple of hours unless @akkadotnet/contributors object :p

@Aaronontheweb
Copy link
Member

err mean @akkadotnet/developers

Aaronontheweb added a commit that referenced this pull request Apr 9, 2015
Script to add Copyright headers & modify files to add header
@Aaronontheweb Aaronontheweb merged commit ce561dd into akkadotnet:dev Apr 9, 2015
@SeanKilleen SeanKilleen deleted the 718-add-copyrights branch April 9, 2015 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants