-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script to add Copyright headers & modify files to add header #820
Conversation
Imo the C# line should be changed into a copyright line too, apache 2 license is clear on this matter, you own the modifications you make. So something along the lines of
And personally, I'd rather see this github link instead of getakka.net. cc @akkadotnet/contributors @akkadotnet/developers thoughts on this? |
@rogeralsing for further reference, there appears to be a guide here. Most examples I've seen so far involve adding some more text -- while the script is mostly ready to go, I won't run the script across all files until we finish the discussion -- #718 is likely a better place. I'm thinking. |
Reflects changes from conversation in akkadotnet#718.
Generated via the script in the tools directory. The only changes made to any files in this commit are the additions of comments in the beginning. Solution builds and all tests pass.
This reverts commit 041c741.
Because clicking a dialog every time a file is opened is not fun for most people.
Generated via the script in the tools directory. All CS / FS files now contain this copyright language. The only changes made to the files in this commit are the addition of the comments. The build still works and all expected tests pass.
@Aaronontheweb @rogeralsing ready for review. |
@rogeralsing @Aaronontheweb it occurs to me that this is a huge commit. While it builds and tests fine, would you prefer I break it up into smaller commits? I didn't see a problem at the time but let me know if you want me to revert this and commit several smaller chunks. |
@SeanKilleen PR is fine as-is. I'm just waiting on getting the API docs stuff working perfectly before I pull this in, just because I'm going to have to make some on-the-fly adjustments to that script I suspect. I'll pull this in within a couple of hours unless @akkadotnet/contributors object :p |
err mean @akkadotnet/developers |
Script to add Copyright headers & modify files to add header
In support of #718, this PR will contain two changes:
.cs
and.fs
files that don't have them