Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix i686 builds #110

Merged
merged 4 commits into from
Oct 22, 2022
Merged

Fix i686 builds #110

merged 4 commits into from
Oct 22, 2022

Conversation

mayeut
Copy link
Contributor

@mayeut mayeut commented Oct 22, 2022

Inline assembly builds are failing in 32-bit, only enable AVX/AVX2 inline assembly in 64-bit mode.
This was already done for SSE* codecs.
Add tests for 32-bit builds.

gcc errors out with `error: ‘asm’ operand has impossible constraints` when building for i686 because there are not enough registers available in i686 mode.
gcc errors out with `error: ‘asm’ operand has impossible constraints` when building for i686 because there are not enough registers available in i686 mode.
@aklomp
Copy link
Owner

aklomp commented Oct 22, 2022

Oops. I knew there were 32-bit SSSE3 machines, but didn't realize that there was such a thing as AVX/AVX2 in a 32-bit context. Nice catch.

Thanks for adding the i686 CI tests, so that this oversight won't happen again.

@aklomp aklomp merged commit fc980a1 into aklomp:master Oct 22, 2022
@aklomp aklomp added the bug label Oct 22, 2022
@aklomp aklomp self-requested a review October 22, 2022 23:10
@mayeut mayeut deleted the test-i686 branch October 23, 2022 09:05
@aklomp aklomp mentioned this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants