fix: typo in macro _AVX_512_ENABLED_BY_OS #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aklomp, can this be reviewed please ? |
aklomp
added a commit
that referenced
this pull request
Sep 11, 2024
- Fix a typo in the AVX512 codec selector. - Allow the user to inhibit CI tests for any codec by setting environment variables. This is needed because CI does not support AVX512 yet. Resolves #145.
This was referenced Sep 11, 2024
|
Reviewed and merged, sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The typo results in a build error when AVX512 is enabled.
This should have been caught by CI but CI disables things that can't be tested: rework CI & tests to build everything and skip tests that can't be run.
We could probably add a test using Intel SDE in order to test everything but that would be for another PR.
based on #144 which fixes the CI workflow.
fixes #146
fixes #147