Move remove_creature_from_reachability calls from the destructor to o…

…n_unload. The avatar never unloads. (CleverRaven#69368)
akrieger · Nov 14, 2023 · e8f77ab · e8f77ab
1 parent 1cf0c0e
commit e8f77ab
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/src/creature.cpp b/src/creature.cpp
@@ -168,12 +168,7 @@ Creature::Creature( Creature && ) noexcept( map_is_noexcept &&list_is_noexcept )
 Creature &Creature::operator=( const Creature & ) = default;
 Creature &Creature::operator=( Creature && ) noexcept = default;
 
-Creature::~Creature()
-{
-    if( g ) {
-        get_map().remove_creature_from_reachability( this );
-    }
-}
+Creature::~Creature() = default;
 
 tripoint Creature::pos() const
 {

diff --git a/src/monster.cpp b/src/monster.cpp
@@ -3703,6 +3703,7 @@ bool monster::will_join_horde( int size )
 void monster::on_unload()
 {
     last_updated = calendar::turn;
+    get_map().remove_creature_from_reachability( this );
 }
 
 void monster::on_load()

diff --git a/src/npc.cpp b/src/npc.cpp
@@ -3196,6 +3196,7 @@ void npc::add_new_mission( class mission *miss )
 
 void npc::on_unload()
 {
+    get_map().remove_creature_from_reachability( this );
 }
 
 // A throtled version of player::update_body since npc's don't need to-the-turn updates.