Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed blinking issue and Frontend redesign #1032

Merged
merged 5 commits into from
Jul 8, 2023
Merged

Fixed blinking issue and Frontend redesign #1032

merged 5 commits into from
Jul 8, 2023

Conversation

Nishitbaria
Copy link
Contributor

@Nishitbaria Nishitbaria commented Jul 8, 2023

Fixes Issue: #945
I have made the following changes in this pull request:

  1. Fixed the page linking issue by redefining the startTime function in the frontend code. The new startTime function uses the toLocaleTimeString method to display the current time in the desired format. Additionally, I have added the requestAnimationFrame method to ensure smooth and efficient updating of the time display.

New startTime function:

function startTime() {
  var today = new Date();
  var time = today.toLocaleTimeString([], { hour: 'numeric', minute: '2-digit', hour12: true });

  document.getElementById('display').innerHTML = time;

  requestAnimationFrame(startTime);
}

startTime();

2.Redesigned the frontend to improve the layout and alignment of the cards in the card-container. I added the justify-center class to the card-container div to align cards.

Please review and merge this pull request. It addresses the issues mentioned and enhances the frontend design. Thank you!

Screenshots

before

image

after:(my work)

image

image
image
@akshitagupta15june ,please review my pull requesta and assign me level for my work

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Nishitbaria! 🎉 Thank you for submitting your pull request for Moksh. Our dedicated team will review it diligently.Your contribution is valuable and we appreciate your efforts to improve our project.

@Nishitbaria
Copy link
Contributor Author

@akshitagupta15june ,please review my pull request

@akshitagupta15june
Copy link
Owner

Hey please remove the three cards as they are not required here, I will add new section for it just shlok generator and footer

@akshitagupta15june
Copy link
Owner

Also the footer is changed please update your codebase

@Nishitbaria
Copy link
Contributor Author

@akshitagupta15june ,i am updating asap.

@akshitagupta15june
Copy link
Owner

can u add updated screenshot, how the page looks and is it reponsive?

@Nishitbaria
Copy link
Contributor Author

Nishitbaria commented Jul 8, 2023

Image

image

Image

image
And it is not responsive,but i can make it responsive with tailwind css,i can create a isuue for that and why you closed issue before merging my pull request?

@Nishitbaria
Copy link
Contributor Author

@akshitagupta15june ,please review changes and merge my pull request

Copy link
Owner

@akshitagupta15june akshitagupta15june left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@akshitagupta15june akshitagupta15june merged commit 0badc8c into akshitagupta15june:main Jul 8, 2023
@akshitagupta15june
Copy link
Owner

yes you can create issue regarding fixing the responsiveness

@Nishitbaria
Copy link
Contributor Author

yes you can create issue regarding fixing the responsiveness

Sure

@Nishitbaria
Copy link
Contributor Author

Hey @akshitagupta15june , I created an issue for making a responsive shlok_page web page. Could you please assign me the issue? I have made an issue here: #1074

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants