-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed blinking issue and Frontend redesign #1032
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @Nishitbaria! 🎉 Thank you for submitting your pull request for Moksh. Our dedicated team will review it diligently.Your contribution is valuable and we appreciate your efforts to improve our project.
@akshitagupta15june ,please review my pull request |
Hey please remove the three cards as they are not required here, I will add new section for it just shlok generator and footer |
Also the footer is changed please update your codebase |
@akshitagupta15june ,i am updating asap. |
can u add updated screenshot, how the page looks and is it reponsive? |
@akshitagupta15june ,please review changes and merge my pull request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
yes you can create issue regarding fixing the responsiveness |
Sure |
Hey @akshitagupta15june , I created an issue for making a responsive shlok_page web page. Could you please assign me the issue? I have made an issue here: #1074 |
Fixes Issue: #945
I have made the following changes in this pull request:
startTime
function in the frontend code. The newstartTime
function uses thetoLocaleTimeString
method to display the current time in the desired format. Additionally, I have added therequestAnimationFrame
method to ensure smooth and efficient updating of the time display.New
startTime
function:2.Redesigned the frontend to improve the layout and alignment of the cards in the card-container. I added the justify-center class to the card-container div to align cards.
Please review and merge this pull request. It addresses the issues mentioned and enhances the frontend design. Thank you!
Screenshots
before
after:(my work)
@akshitagupta15june ,please review my pull requesta and assign me level for my work