Skip to content
This repository has been archived by the owner on Dec 2, 2022. It is now read-only.

0x kitsune/api flag #261

Merged
merged 11 commits into from
Aug 30, 2022
Merged

0x kitsune/api flag #261

merged 11 commits into from
Aug 30, 2022

Conversation

0xKitsune
Copy link
Contributor

PR for #256.

I added a new CLI flag called enable-api that takes 1 or more arguments to enable the various RPC API options.

 /// Enable  API options
#[clap(long, min_values(1))]
pub enable_api: Vec<String>

Example Usage:
--enable-api eth otterscan

Right now, pattern matching is used to determine which APIs to enable. I can add invalid character handling or any other input sanitation but wanted to check if this PR was in the right direction before continuing. Please let me know any feedback that you might have.

@CLAassistant
Copy link

CLAassistant commented Aug 24, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@0xKitsune 0xKitsune closed this Aug 25, 2022
@vorot93 vorot93 reopened this Aug 25, 2022
vorot93
vorot93 reviewed Aug 25, 2022
View reviewed changes
bin/akula.rs Show resolved Hide resolved
vorot93
vorot93 reviewed Aug 25, 2022
View reviewed changes
bin/akula.rs Outdated Show resolved Hide resolved
vorot93
vorot93 suggested changes Aug 25, 2022
View reviewed changes
Copy link
Member

@vorot93 vorot93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

vorot93
vorot93 reviewed Aug 26, 2022
View reviewed changes
bin/akula.rs Outdated Show resolved Hide resolved
vorot93
vorot93 reviewed Aug 26, 2022
View reviewed changes
bin/akula.rs Outdated Show resolved Hide resolved
@vorot93
Copy link
Member

vorot93 commented Aug 26, 2022

Also, please sign the CLA.

@0xKitsune
Copy link
Contributor Author

Also, please sign the CLA.

Let me know if there is anything else you need from me or any other changes to make.

@vorot93
Copy link
Member

vorot93 commented Aug 30, 2022

LGTM, but also please duplicate this in akula-rpc.

vorot93
vorot93 approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@vorot93 vorot93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@vorot93 vorot93 enabled auto-merge (squash) August 30, 2022 22:59
@0xKitsune
Copy link
Contributor Author

Thanks for a smooth process, looking forward to contributing more to the code base.

@vorot93 vorot93 merged commit 34a01e9 into akula-bft:master Aug 30, 2022
brilliant-lx pushed a commit to bnb-chain/akula that referenced this pull request Sep 19, 2022
@0xKitsune @brilliant-lx
--enable-api flag (akula-bft#261)
295aa11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vorot93 vorot93 vorot93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xKitsune @CLAassistant @vorot93