Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1172] Add monitoring response #1173

Merged
merged 4 commits into from
Feb 14, 2024
Merged

[#1172] Add monitoring response #1173

merged 4 commits into from
Feb 14, 2024

Conversation

navins94
Copy link
Contributor

@navins94 navins94 commented Feb 13, 2024 •
edited
Loading

@ifirmawan ifirmawan marked this pull request as ready for review February 14, 2024 04:08
ifirmawan
ifirmawan requested changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@ifirmawan ifirmawan left a comment •
edited by navins94
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO/DONE

  • Last response column is still not available for approver in all tabs
  • Last response should be read-only
  • Monitoring icon is still not available for approver in all tabs

@coveralls
Copy link

Coverage Status

coverage: 81.588% (-0.1%) from 81.709%
when pulling afa1d88 on feature/1172-showing-monitoring-data-in-approval-page
into 02fe5dd on develop.

@ifirmawan ifirmawan merged commit 21cc1e5 into develop Feb 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ifirmawan ifirmawan ifirmawan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@navins94 @coveralls @ifirmawan