-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add enableRelaxedEndCondition support #25
Comments
Thanks for the notice. ghidra-firmware-utils doesn't actually use XZ for Java directly - it uses Apache commons-compress, which is already included in Ghidra. I think this required manual installation of the jar in the past (at least that's what I thought at the time: cd74930 🤷♀️ ), but it seems to work without it. Ghidra already includes it:
I'll remove the explicit XZ for Java dependency as it's no longer needed. Regarding
This should get addressed once Ghidra updates the commons-compress dependency. It might be worth opening an issue (or submitting a PR!) in https://github.com/NationalSecurityAgency/ghidra to let the Ghidra maintainers know about this. By the way, do you have any examples of firmware binaries with compressed sections that require |
Thanks for the quick reply. I noticed the usage of apache commons-compress, but mentioned XZ to avoid confusion about what class has the method. Regarding firmware binaries: I'm interested in the HP Pavilion 23-q109nb bios, trying to figure out how the nvram var whitelist works. |
XZ 1.9 introduced a new method to LZMAInputStream. When this method is called before any data from the stream is read, the absence of EOS doesn't trigger an exception.
The text was updated successfully, but these errors were encountered: