Apply suggestions from code review

Co-authored-by: Raphael Taylor-Davies <[email protected]>
alamb · Jul 19, 2023 · 6d1526f · 6d1526f
1 parent 4814da4
commit 6d1526f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/datafusion/core/src/physical_plan/aggregates/order/full.rs b/datafusion/core/src/physical_plan/aggregates/order/full.rs
@@ -129,7 +129,7 @@ impl GroupOrderingFull {
         batch_hashes: &[u64],
         total_num_groups: usize,
     ) {
-        assert!(total_num_groups > 0);
+        assert_ne!(total_num_groups, 0);
         assert_eq!(group_indices.len(), batch_hashes.len());
 
         // copy any hash values

diff --git a/datafusion/core/src/physical_plan/aggregates/order/partial.rs b/datafusion/core/src/physical_plan/aggregates/order/partial.rs
@@ -91,7 +91,7 @@ enum State {
 
     /// Data is in progress.
     InProgress {
-        /// first group index with the sort_key
+        /// Smallest group index with the sort_key
         current_sort: usize,
         /// The sort key of group_index `current_sort`
         sort_key: OwnedRow,