Min/Max for primitives

alamb · Jul 5, 2023 · 9d2c7bf · 9d2c7bf
1 parent 6e740a4
commit 9d2c7bf
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 25 deletions.
diff --git a/datafusion/physical-expr/src/aggregate/groups_accumulator/accumulate.rs b/datafusion/physical-expr/src/aggregate/groups_accumulator/accumulate.rs
@@ -717,29 +717,6 @@ mod test {
 
             let null_buffer = null_state.build();
 
-            if null_buffer != expected_null_buffer {
-                if let (Some(null_buffer), Some(expected_null_buffer)) =
-                    (null_buffer.as_ref(), expected_null_buffer.as_ref())
-                {
-                    null_buffer
-                        .iter()
-                        .zip(expected_null_buffer.iter())
-                        .enumerate()
-                        .for_each(|(i, (valid, expected_valid))| {
-                            println!(
-                                "nulls[{i}]: valid: {valid}, expected: {expected_valid}"
-                            );
-                            println!(
-                                "  expected_seen_values: {} expected_null_input: {}",
-                                expected_seen_values.contains(&i),
-                                expected_null_input.contains(&i)
-                            );
-
-                            assert_eq!(valid, expected_valid, "Index {i}");
-                        })
-                };
-            }
-
             assert_eq!(null_buffer, expected_null_buffer);
         }
 

diff --git a/datafusion/physical-expr/src/aggregate/sum.rs b/datafusion/physical-expr/src/aggregate/sum.rs
@@ -478,8 +478,7 @@ impl RowAccumulator for SumRowAccumulator {
     }
 }
 
-/// An accumulator to compute the sum of PrimitiveArray<T>.
-/// Stores values as native types, and does overflow checking
+/// An accumulator to compute the sum of values in [`PrimitiveArray<T>`]
 #[derive(Debug)]
 struct SumGroupsAccumulator<T>
 where