Merge alandtse/dev #136
Merged
Merge alandtse/dev #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keatontaylor
approved these changes
Mar 25, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per our discussion in #132, this completely disables polling if websocket is detected. It also will do new device detection based on websockets. Should resolve #132.
It does not handle bluetooth changes so is not a complete fix until your bluetooth update changes are merged in. In theory you could simply force update_devices(no_throttle=True) after setting the
new_deviceskey I mentioned in the other thread and the bluetooth update will be done as well. Alternatively, you could move the bluetooth update over to it's own function which you would then call.Also added some miscellaneous changes: