Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for TS type-only re-exports #533

Merged
merged 1 commit into from
May 17, 2020
Merged

Add support for TS type-only re-exports #533

merged 1 commit into from
May 17, 2020

Conversation

Rugvip
Copy link
Contributor

@Rugvip Rugvip commented May 16, 2020

Hi! I ran into some trouble using type re-exports in TypeScript.

export type { T } from './T';

would be transpiled to

       from './T';

The syntax form is mentioned in the PR adding the functionality to TS: microsoft/TypeScript#35200

Wondering if this looks like an alright fix?

alangpierce
alangpierce approved these changes May 17, 2020
View reviewed changes
Copy link
Owner

@alangpierce alangpierce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you!

@alangpierce alangpierce merged commit 2733d22 into alangpierce:master May 17, 2020
@Rugvip Rugvip mentioned this pull request May 17, 2020
Merged
@Rugvip Rugvip deleted the ts-reexport branch May 17, 2020 22:50
@alangpierce
Copy link
Owner

@Rugvip I just released this as 3.14.1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alangpierce alangpierce alangpierce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rugvip @alangpierce