Add datasource to the SliceAddView modal (apache#3884)

alanmcruickshank · Nov 17, 2017 · c871b08 · c871b08
1 parent f0acc11
commit c871b08
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/superset/assets/javascripts/dashboard/components/SliceAdder.jsx b/superset/assets/javascripts/dashboard/components/SliceAdder.jsx
@@ -54,7 +54,8 @@ class SliceAdder extends React.Component {
         const slices = response.result.map(slice => ({
           id: slice.id,
           sliceName: slice.slice_name,
-          vizType: slice.vizType,
+          vizType: slice.viz_type,
+          datasourceLink: slice.datasource_link,
           modified: slice.modified,
         }));
 
@@ -165,6 +166,14 @@ class SliceAdder extends React.Component {
             >
               {t('Viz')}
             </TableHeaderColumn>
+            <TableHeaderColumn
+              dataField="datasourceLink"
+              dataSort
+              // Will cause react-bootstrap-table to interpret the HTML returned
+              dataFormat={datasourceLink => datasourceLink}
+            >
+              {t('Datasource')}
+            </TableHeaderColumn>
             <TableHeaderColumn
               dataField="modified"
               dataSort

diff --git a/superset/views/core.py b/superset/views/core.py
@@ -451,7 +451,7 @@ class SliceAsync(SliceModelView):  # noqa
 class SliceAddView(SliceModelView):  # noqa
     list_columns = [
         'id', 'slice_name', 'slice_link', 'viz_type',
-        'owners', 'modified', 'changed_on']
+        'datasource_link', 'owners', 'modified', 'changed_on']
 
 
 appbuilder.add_view_no_menu(SliceAddView)