feat: support Uint8ArrayLists in the same way as Uint8Arrays #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to support no-copy operations, relax the requirement for `Uint8Array`s to just require a `.byteLength` property since that's all we access. Generics can then be used to ensure the correct value type is used as normal.
|
cc @mpetrunic |
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
==========================================
+ Coverage 96.58% 96.97% +0.38%
==========================================
Files 3 3
Lines 733 760 +27
Branches 170 170
==========================================
+ Hits 708 737 +29
+ Misses 25 23 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
mpetrunic
reviewed
Aug 2, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Aug 2, 2022
## [3.1.0](v3.0.0...v3.1.0) (2022-08-02) ### Features * support Uint8ArrayLists in the same way as Uint8Arrays ([#30](#30)) ([7bae368](7bae368))
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support no-copy operations, relax the requirement for
Uint8Arrays to just require a.byteLengthproperty since that's all we access.Generics can then be used to ensure the correct value type is used as normal.
Everything still defaults to
Uint8Arrays so this is non-breaking.