Debug logging of untouched index buffers

alasram · Sep 17, 2024 · f536534 · f536534
1 parent 0e0c8da
commit f536534
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 0 deletions.
diff --git a/src/mbgl/gl/drawable_gl.cpp b/src/mbgl/gl/drawable_gl.cpp
@@ -9,6 +9,7 @@
 #include <mbgl/shaders/gl/shader_program_gl.hpp>
 #include <mbgl/util/instrumentation.hpp>
 #include <mbgl/util/logging.hpp>
+#include <mbgl/gl/index_buffer_resource.hpp>
 
 namespace mbgl {
 namespace gl {
@@ -31,6 +32,8 @@ void DrawableGL::draw(PaintParameters& parameters) const {
 
     auto& context = static_cast<gl::Context&>(parameters.context);
 
+    impl->drawTouchBuffer();
+
     if (shader) {
         const auto& shaderGL = static_cast<const ShaderProgramGL&>(*shader);
         if (shaderGL.getGLProgramID() != context.program.getCurrentValue()) {
@@ -281,5 +284,10 @@ void DrawableGL::unbindTextures() const {
     }
 }
 
+void DrawableGL::Impl::drawTouchBuffer() {
+    const auto& indexBuf = static_cast<IndexBufferGL&>(*indexes->getBuffer());
+    indexBuf.buffer->getResource<gl::IndexBufferResource>().drawTouched = true;
+}
+
 } // namespace gl
 } // namespace mbgl
diff --git a/src/mbgl/gl/drawable_gl_impl.hpp b/src/mbgl/gl/drawable_gl_impl.hpp
@@ -51,6 +51,8 @@ class DrawableGL::Impl final {
     GLfloat pointSize = 0.0f;
 
     size_t vertexAttrId = 0;
+
+    void drawTouchBuffer();
 };
 
 struct DrawableGL::DrawSegmentGL final : public gfx::Drawable::DrawSegment {

diff --git a/src/mbgl/gl/index_buffer_resource.cpp b/src/mbgl/gl/index_buffer_resource.cpp
@@ -1,6 +1,7 @@
 #include <mbgl/gl/context.hpp>
 #include <mbgl/gl/index_buffer_resource.hpp>
 #include <mbgl/util/instrumentation.hpp>
+#include <mbgl/util/logging.hpp>
 
 namespace mbgl {
 namespace gl {
@@ -16,6 +17,21 @@ IndexBufferResource::~IndexBufferResource() noexcept {
     auto& stats = buffer.get_deleter().context.renderingStats();
     stats.memIndexBuffers -= byteSize;
     assert(stats.memIndexBuffers >= 0);
+
+    static int numDestroyedBuffers = 0;
+    static int numTouchedBuffers = 0;
+    ++numDestroyedBuffers;
+
+    if (!drawTouched) {
+        Log::Error(
+            Event::OpenGL,
+            std::string(
+                "################### Calling ~IndexBufferResource on a resource that is never touched by a draw. ") +
+                std::to_string(numDestroyedBuffers) + " total destroyed index buffers, " +
+                std::to_string(numTouchedBuffers) + " total destroyed and touched by a draw.");
+    } else {
+        ++numTouchedBuffers;
+    }
 }
 
 } // namespace gl

diff --git a/src/mbgl/gl/index_buffer_resource.hpp b/src/mbgl/gl/index_buffer_resource.hpp
@@ -13,6 +13,8 @@ class IndexBufferResource : public gfx::IndexBufferResource {
 
     UniqueBuffer buffer;
     int byteSize;
+
+    bool drawTouched = false;
 };
 
 } // namespace gl