-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return (entity-)type for collections #170
Conversation
👍 |
Hm, finding the type still needs more work in the examle. Not part of the API, but having a working example is crucial for a) documentation b) checking of the API is "sane": When the collection I request is public, then I can't use Additionally it might be wise to wait for #168 to complete so we can add full event collection support in this PR. |
Signed-off-by: Johannes Dewender <[email protected]>
The example itself still runs on mbngs 0.5 and doesn't display the types in this case. A request for a collection of events fails with a message that events are not yet implemented. Signed-off-by: Johannes Dewender <[email protected]>
Signed-off-by: Johannes Dewender <[email protected]>
I updated the example to reduce the complexity for checking the type (just tries I also added XML tests for collections. I will update the branch again when events are merged (and implement events for collections). |
I don't think we should wait for #168 for this. Note that a work read endpoint has been released: http://tickets.musicbrainz.org/browse/MBS-8459 but we still need write. I wonder if we can rework the collection methods to make this easier to use. |
I'm happy to 🚢 as-is |
see pull request #170 Signed-off-by: Johannes Dewender <[email protected]>
This is part of #154.
This works fine so far, but lists of events can no yet be returned because events are not yet implemented (see #168).
Getting the type of a collection by MBID is a bit clumsy.
If the collection is not from the user that is currently authenticated we basically guess that it is of type release and request the list of releases. We will request events otherwise later.
Maybe there is a better option to find out the type, see:
http://chatlogs.musicbrainz.org/musicbrainz-devel/2015/2015-06/2015-06-10.html#T16-17-51-539040