add progress display handler and api #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new package- Observe- for owning user- oriented displays like progress bars. This PR adds an initial progress bar to onedrive backups as a proof-of-concept. The API is more important than the specific progress bar package at this time. Future changes may opt for a different pkg.
|
Kudos, SonarCloud Quality Gate passed!
|
Closed
vkamra
approved these changes
Oct 10, 2022
Aviator status
This PR was merged using Aviator. |
|
Thanks @ryanfkeepers - This one looks promising for the multi-pb use case - https://github.com/vbauerster/mpb/ |
ryanfkeepers
added a commit
that referenced
this pull request
Oct 11, 2022
## Description Adds a new package- Observe- for owning user- oriented displays like progress bars. This PR adds an initial progress bar to onedrive backups as a proof-of-concept. The API is more important than the specific progress bar package at this time. Future changes may opt for a different pkg. Display format currently looks like: ``` 59% [=============> ] (6.9/12 kB, 14 MB/s) | Item_Name.txt ``` Known Issues: * the `progressbar` package does not support multiline output, and [the author is not planning to add support](schollz/progressbar#6). This causes concurrent items to overwrite each other. We will either need to fork the library, or change to a different one. ## Type of change - [x] 🌻 Feature ## Issue(s) * #1112 ## Test Plan - [x] 💪 Manual - [x] ⚡ Unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new package- Observe- for owning user-
oriented displays like progress bars. This PR adds
an initial progress bar to onedrive backups as a
proof-of-concept. The API is more important than
the specific progress bar package at this time.
Future changes may opt for a different pkg.
Display format currently looks like:
Known Issues:
progressbarpackage does not support multiline output, and the author is not planning to add support. This causes concurrent items to overwrite each other. We will either need to fork the library, or change to a different one.Type of change
Issue(s)
Test Plan